Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Addresses a flaky Playwright test by adding stronger UI state assertions and ensuring workspace tab removals trigger an immediate save.
Changes:
- Trigger
flushWorkspaceSave()(when available) after removing a workspace tab instead of only queuing a debounced save. - Add Playwright assertions to wait for render-mode/style-mode selects and editor content to reflect changes before continuing.
- Simplify the “persists style mode across reload” test assertions to rely on
#style-modevalue across reload.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/modules/app-core/workspace-tab-mutations-controller.js |
Flushes workspace save immediately after a tab removal to reduce persistence race conditions. |
src/modules/app-core/workspace-controllers-setup.js |
Wires flushWorkspaceSave into the tab mutations controller. |
playwright/rendering-modes.spec.ts |
Adds synchronization expectations to reduce flakiness around mode switching and editor updates. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.